config-linux: Require at least one entry in linux.seccomp.sycalls[].names #769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ames
I expect the (undocumented) intention here is to iterate through
'names' and call seccomp_rule_add(3) or similar for each name. In
that case, an empty 'names' makes the whole syscall entry a no-op, and
with this commit we can warn users who are validating such configs.
If, on the other hand, we were comfortable with no-op syscall entries,
we'd want to make 'names' OPTIONAL.
Warning folks who accidentally empty (or don't set) 'names' seems more
useful to me, and doesn't restrict the useful config space, so that's
what I've gone with in this commit.
minItems is documented in [1], and there is an example of its use in
[2]:
"options": {
"type": "array",
"minItems": 1,
"items": { "type": "string" },
"uniqueItems": true
},
[1]: https://tools.ietf.org/html/draft-wright-json-schema-validation-00#section-5.11
[2]: http://json-schema.org/example2.html
Signed-off-by: W. Trevor King <[email protected]>
Contributor
Author
|
This is a breaking change (adding a new MUST-level restriction), so it would be good to get it into 1.0. Otherwise we'd have to delay this until 2.0. |
Contributor
|
LGTM |
2 similar comments
Member
|
LGTM |
Member
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I expect the (undocumented) intention here is to iterate through
namesand callseccomp_rule_add(3)or similar for each name. In that case, an emptynamesmakes the whole syscall entry a no-op, and with this commit we can warn users who are validating such configs.If, on the other hand, we were comfortable with no-op syscall entries, we'd want to make
namesOPTIONAL.Warning folks who accidentally empty (or don't set)
namesseems more useful to me, and doesn't restrict the useful config space, so that's what I've gone with in this commit.minItemsis documented here, and there is an example of its use here:Part of #762.