Make mount type and source optional #699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM |
wking
reviewed
Feb 27, 2017
Contributor
wking
left a comment
wking
left a comment
There was a problem hiding this comment.
And similar Go/JSON-Schema updates for source.
| * Windows: one mount destination MUST NOT be nested within another mount (e.g., c:\\foo and c:\\foo\\bar). | ||
| * Solaris: corresponds to "dir" of the fs resource in zonecfg(8). | ||
| * **`type`** (string, REQUIRED) The filesystem type of the filesystem to be mounted. | ||
| * **`type`** (string, OPTIONAL) The filesystem type of the filesystem to be mounted. |
Contributor
Contributor
These are optional on multiple platforms and should be left up to the runtime/host system for validation. Closes opencontainers#470 Signed-off-by: Michael Crosby <[email protected]>
crosbymichael
force-pushed
the
mount-optional
branch
from
7c5796d to
5246151
Compare
Member
Author
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are optional on multiple platforms and should be left up to the
runtime/host system for validation.
Closes #470
Signed-off-by: Michael Crosby [email protected]