Skip to content

Conversation

@vapier
Copy link
Contributor

@vapier vapier commented Nov 4, 2016

This matches the config-linux.md spec which says these are both int64.

@wking
Copy link
Contributor

wking commented Nov 4, 2016

Missing a sign-off [1,2], but otherwise 23faf4c looks good to me
(fixing a typo from #550).

This matches the config-linux.md spec which says these are both int64.

Signed-off-by: Mike Frysinger <[email protected]>
@vapier
Copy link
Contributor Author

vapier commented Nov 5, 2016

i didn't think s-o-b tags were used, but i guess it's hard to see real commits in the history with the huge merge noise. added now!

@wking
Copy link
Contributor

wking commented Nov 5, 2016

On Fri, Nov 04, 2016 at 05:11:41PM -0700, Mike Frysinger wrote:

… i guess it's hard to see real commits in the history with the huge
merge noise…

That's what --no-merges is for ;). 7872d3d looks good to me.

@vapier
Copy link
Contributor Author

vapier commented Nov 7, 2016

thanks for the tip. that'll work locally, but it doesn't help with online systems.

@crosbymichael
Copy link
Member

crosbymichael commented Nov 7, 2016

LGTM

Approved with PullApprove

1 similar comment
@dqminh
Copy link
Contributor

dqminh commented Nov 7, 2016

LGTM

Approved with PullApprove

@dqminh dqminh merged commit 2d49cf4 into opencontainers:master Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants