[Runtime] Fix formatting and clarify status values #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reading the PDF, this line is not clear if it applies just to status or to all state values Signed-off-by: Rob Dolin <[email protected]>
wking
reviewed
Sep 19, 2016
| * `stopped`: the container has been created and the user-specified code has been executed but is no longer running | ||
| * Additional `status` values MAY be defined by the runtime, however, they MUST be used to represent new runtime states not defined above. | ||
|
|
||
| Additional values MAY be defined by the runtime, however, they MUST be used to represent new runtime states not defined above. |
Contributor
There was a problem hiding this comment.
Maybe if we use a four-space indent? Possibly missed by #495.
Collaborator
Author
|
Tagging @vbatts to take a look. Thanks in advance. |
Contributor
|
LGTM |
Contributor
|
I think we should use a four-space indent here as suggested by @wking |
Contributor
|
@RobDolinMS Can you check if the four-space indent fixes your problem? I've tested and it looks good to me. Put that sentence with these states doesn't look reasonable to me. |
hqhq
added a commit
to hqhq/runtime-spec
that referenced
this pull request
Nov 3, 2016
This carries opencontainers#578 and fixes some other format issues. Signed-off-by: Qiang Huang <[email protected]>
Contributor
|
@RobDolinMS I've carried this in #608 , so I'll close this one, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading the PDF, this line is not clear if it applies just to status or to all state values
Signed-off-by: Rob Dolin [email protected]