Skip to content

Conversation

@jonboulle
Copy link
Contributor

Signed-off-by: Jonathan Boulle [email protected]

per #282 (comment)

@hqhq
Copy link
Contributor

hqhq commented Dec 25, 2015

LGTM

@arcnmx
Copy link
Contributor

arcnmx commented Dec 29, 2015

Oh, one other item I forgot about that should be omitempty is runtime/linux's rootfsPropagation.

@hqhq
Copy link
Contributor

hqhq commented Dec 30, 2015

@arcnmx Thanks, @jonboulle Can you update for that? Thanks.

@jonboulle
Copy link
Contributor Author

done

On Wed, Dec 30, 2015 at 2:16 AM, Qiang Huang [email protected]
wrote:

@arcnmx https://github.com/arcnmx Thanks, @jonboulle
https://github.com/jonboulle Can you update for that? Thanks.


Reply to this email directly or view it on GitHub
#283 (comment).

@hqhq
Copy link
Contributor

hqhq commented Dec 31, 2015

@jonboulle You need to sign your commit.

@jonboulle
Copy link
Contributor Author

Sigh. Done.

On Thu, Dec 31, 2015 at 12:15 PM, Qiang Huang [email protected]
wrote:

@jonboulle https://github.com/jonboulle You need to sign your commit.


Reply to this email directly or view it on GitHub
#283 (comment).

@hqhq
Copy link
Contributor

hqhq commented Jan 2, 2016

Thanks, still LGTM.

@vbatts
Copy link
Member

vbatts commented Jan 4, 2016

LGTM

vbatts added a commit that referenced this pull request Jan 4, 2016
Appropriately mark optional fields as omitempty
@vbatts vbatts merged commit 3c294d5 into opencontainers:master Jan 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants