Skip to content

Conversation

@laijs
Copy link
Contributor

@laijs laijs commented Nov 17, 2015

No description provided.

@hqhq
Copy link
Contributor

hqhq commented Nov 17, 2015

Lifecycle modification is on going in #231 , this PR needs to be hold on.

@laijs
Copy link
Contributor Author

laijs commented Nov 18, 2015

The intention of this pr is, as its title said, using the lifecycle states to define the hooks.
it has something(changing to the lifecycle) conflicting with #231, but this part is unimportant.
I will remove this part ("remove (process) from lifecycle states" and the fine grain cross reference), and re-summit the pr. thx.

@vbatts
Copy link
Member

vbatts commented Nov 20, 2015

This looks fine for the most part. The switch from "exits" -> "stopped" seems to imply the hooks may get triggered before the container has fully ended. Like if the pid(s) are sent signals to terminate, but they hang in a Wait state, would the hooks still get called?

@philips
Copy link
Contributor

philips commented Nov 25, 2015

This PR is too confusing. "container is started" is confusing: the only way it has meaning is if we agree on a term that isn't "container" for the application process.

@vbatts
Copy link
Member

vbatts commented Dec 9, 2015

#231 is merged. Please update.

@laijs laijs closed this Mar 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants