Skip to content

.tools: Fix redundant r.Pass check when 'fail == 0' #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wking wants to merge 2 commits into from
Closed

.tools: Fix redundant r.Pass check when 'fail == 0' #174

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66e9ac3
.tools: Remove redundant r.Pass check when 'fail == 0'
wking Sep 10, 2015
650828c
.tools: Make -v output comply with TAP version 13
wking Sep 12, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions .tools/validate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,26 +68,30 @@ func main() {
}

results := ValidateResults{}
for _, commit := range c {
fmt.Printf(" * %s %s ... ", commit["abbreviated_commit"], commit["subject"])

if *flVerbose {
fmt.Println("TAP version 13")
fmt.Printf("1..%d\n", len(c)*len(DefaultRules))
}
for i, commit := range c {
fmt.Printf("# %s %s ... ", commit["abbreviated_commit"], commit["subject"])
vr := ValidateCommit(commit, DefaultRules)
results = append(results, vr...)
if _, fail := vr.PassFail(); fail == 0 {
fmt.Println("PASS")
if *flVerbose {
for _, r := range vr {
if r.Pass {
fmt.Printf(" - %s\n", r.Msg)
}
}
}
} else {
fmt.Println("FAIL")
// default, only print out failed validations
for _, r := range vr {
if !r.Pass {
fmt.Printf(" - %s\n", r.Msg)
}
for j, r := range vr {
if *flVerbose {
if r.Pass {
fmt.Printf("ok")
} else {
fmt.Printf("not ok")
}
fmt.Printf(" %d - %s\n", i*len(DefaultRules)+j+1, r.Msg)
} else if !r.Pass {
fmt.Printf("not ok - %s\n", r.Msg)
}
}
}
Expand Down