travis: fix DCO validation for merges #170
Conversation
.tools/validate.go
Outdated
There was a problem hiding this comment.
Instead of splitting at consume-time, it seems cleaner to make CommitEntry.Parent a CommitEntry.Parents array and parse at commit-lookup time.
There was a problem hiding this comment.
meh. that would be another separated shell-out, and would then also have to be done for abbreviated parent as well.
There was a problem hiding this comment.
On Thu, Sep 10, 2015 at 06:26:27AM -0700, Vincent Batts wrote:
@@ -16,6 +16,12 @@ import (
var DefaultRules = []ValidateRule{
func(c CommitEntry) (vr ValidateResult) {
vr.CommitEntry = c
if len(strings.Split(c.Parent, " ")) > 1 {meh. that would be another separated shell-out…
Why? Can't you just have:
… "parents": ["%P"], "abbreviated_parents": ["%p"], …,
in prettyLogFormat, and then:
c.Parents = strings.Split(c.Parents, " ")
c.AbbreviatedParents = strings.Split(c.AbbreviatedParents, " ")
after your Unmarshal?
merged PRs do not have DCO, so do not check for them Signed-off-by: Vincent Batts <[email protected]>
Accomplishing the same access to the commit entry, with more readable code. Reported-by: Lai Jiangshan <[email protected]> Signed-off-by: Vincent Batts <[email protected]>
vbatts
force-pushed
the
fix-dco-validate-on-merges
branch
from
546d18a to
5a654b9
Compare
|
@laijs per https://github.com/opencontainers/specs/pull/167/files#r39153774 see the cleanup commit. |
|
LGTM |
|
@mrunalp review? |
|
@vbatts Looking |
|
LGTM |
travis: fix DCO validation for merges
4 participants
merged PRs do not have DCO, so do not check for them
#169
Signed-off-by: Vincent Batts [email protected]