Disallow self-LGTMs #863
Merged
Disallow self-LGTMs #863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As opencontainers/project-template#13 is merged, change pullapprove accordingly. Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
Member
|
Can you also include the |
Contributor
Author
|
@cyphar I think the plan should not be that we sync these docs to every projects of OCI when they changed, if we want to maintain these docs in one place, we might need some action like we did in runtime-spec for code-of-conduct.md, that's something we need to figure out. |
Member
|
If we're going to do that, we should link the files IMO. LGTM |
Contributor
|
LGTM |
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
…ched config: Explicily make consoleSize unspecified if terminal is false or unset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As opencontainers/project-template#13
is merged, change pullapprove accordingly.
Signed-off-by: Qiang Huang h.huangqiang@huawei.com