Add PullApprove support #847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enforce 2 LGTMs for pull requests. Signed-off-by: Chris Aniszczyk <[email protected]>
caniszczyk
force-pushed
the
add-pull-approve
branch
from
c899372 to
e2fd7c1
Compare
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
Contributor
|
Don't we need a new team like |
Member
|
Actually, shouldn't this team be |
Contributor
|
@cyphar |
Member
|
Hmmm. Yeah, fair point. I've request to join |
wking
added a commit
to wking/oci-project-template
that referenced
this pull request
Sep 9, 2016
The signoff requirement catches us up with fcc7f42 (Add contributing and maintainer guidelines, 2016-05-03, opencontainers#1). The author ignore catches us up with c82a2e7 (MAINTAINERS: disallow self-LGTMs, 2016-05-27, opencontainers#13). The push reset catches us up with opencontainers/runtime-spec@aa9f3a26 (Add PullApprove checks, 2016-05-26, opencontainers/runtime-spec#458), opencontainers/image-spec@95a46754d (Add PullApprove support to enforce review, 2016-06-01, opencontainers/image-spec#101) and opencontainers/runc@e2fd7c11 (Add PullApprove support, 2016-05-26, opencontainers/runc#847). Signed-off-by: W. Trevor King <[email protected]>
wking
added a commit
to wking/oci-project-template
that referenced
this pull request
Sep 9, 2016
The signoff requirement catches us up with fcc7f42 (Add contributing and maintainer guidelines, 2016-05-03, opencontainers#1). The author ignore catches us up with c82a2e7 (MAINTAINERS: disallow self-LGTMs, 2016-05-27, opencontainers#13). The push reset catches us up with opencontainers/runtime-spec@aa9f3a26 (Add PullApprove checks, 2016-05-26, opencontainers/runtime-spec#458), opencontainers/image-spec@95a46754d (Add PullApprove support to enforce review, 2016-06-01, opencontainers/image-spec#101) and opencontainers/runc@e2fd7c11 (Add PullApprove support, 2016-05-26, opencontainers/runc#847). Signed-off-by: W. Trevor King <[email protected]>
wking
added a commit
to wking/oci-project-template
that referenced
this pull request
Sep 9, 2016
The sign-off requirement catches us up with fcc7f42 (Add contributing and maintainer guidelines, 2016-05-03, opencontainers#1). The author ignore catches us up with c82a2e7 (MAINTAINERS: disallow self-LGTMs, 2016-05-27, opencontainers#13). The push reset catches us up with opencontainers/runtime-spec@aa9f3a26 (Add PullApprove checks, 2016-05-26, opencontainers/runtime-spec#458), opencontainers/image-spec@95a46754d (Add PullApprove support to enforce review, 2016-06-01, opencontainers/image-spec#101) and opencontainers/runc@e2fd7c11 (Add PullApprove support, 2016-05-26, opencontainers/runc#847). Signed-off-by: W. Trevor King <[email protected]>
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
config: Replace "SHOULD consider" for 'rootfs' path value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforce 2 LGTMs for pull requests.