Skip to content

Conversation

@mrunalp
Copy link
Contributor

@mrunalp mrunalp commented Jan 26, 2016

This leaves out the internal conversions as we may need to consider
docker backward compatibility for those changes.

Signed-off-by: Mrunal Patel [email protected]

This leaves out the internal conversions as we may need to consider
docker backward compatibility for those changes.

Signed-off-by: Mrunal Patel <[email protected]>
@mrunalp
Copy link
Contributor Author

mrunalp commented Jan 26, 2016

@crosbymichael @LK4D4 @hqhq ping

@hqhq
Copy link
Contributor

hqhq commented Jan 26, 2016

@mrunalp Don't we want to change fields in Resources to be pointer as specs defined? I think that's the point we use pointers in specs.

Or are you planning to do this in a following-up PR?

@mrunalp
Copy link
Contributor Author

mrunalp commented Jan 26, 2016

@hqhq Yes, I think we can do those changes in a follow up.

@hqhq
Copy link
Contributor

hqhq commented Jan 26, 2016

LGTM

1 similar comment
@LK4D4
Copy link
Contributor

LK4D4 commented Jan 26, 2016

LGTM

LK4D4 added a commit that referenced this pull request Jan 26, 2016
Update github.com/opencontainers/specs to a7b5092
@LK4D4 LK4D4 merged commit 32ad3ba into opencontainers:master Jan 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants