[1.3] fix fd leaks and detect them as comprehensively as possible #5028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyphar
requested changes
Nov 20, 2025
Member
cyphar
left a comment
cyphar
left a comment
There was a problem hiding this comment.
You should update to go-selinux v1.13.1 here -- v1.12.0 is insecure. Also filepath-securejoin v0.5.2 has been released.
lifubang
force-pushed
the
ci-detect-fdleak-try-best-1.3
branch
from
acf798b to
b1ec8d6
Compare
cyphar
approved these changes
Nov 20, 2025
cyphar
changed the title
Co-authored-by: Aleksa Sarai <[email protected]> Signed-off-by: lifubang <[email protected]> (cherry picked from commit ba7f46d) Signed-off-by: lifubang <[email protected]>
Signed-off-by: lifubang <[email protected]> (cherry picked from commit e027288) Signed-off-by: lifubang <[email protected]>
Signed-off-by: lifubang <[email protected]> (cherry picked from commit 9a5e626) Signed-off-by: lifubang <[email protected]>
elinux from v1.13.0 to v1.13.1 Signed-off-by: lifubang <[email protected]>
The dependency was initially slated for an upgrade from v0.6.0 to v0.6.1 to address an fd leak. However, due to compatibility constraints, we instead downgrade to v0.5, using v0.5.2 which includes a backported fix for the same issue. Signed-off-by: lifubang <[email protected]>
Signed-off-by: lifubang <[email protected]> (cherry picked from commit d870650) Signed-off-by: lifubang <[email protected]>
lifubang
force-pushed
the
ci-detect-fdleak-try-best-1.3
branch
from
b1ec8d6 to
ebea1f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #5026
Fix: #5021
Fix: #5007
Close: #5022
Close: #5024
Without deferring the closure of this file descriptor, starting a container with a very large number of devices can hit the
RLIMIT_NOFILElimit.The dependency was initially slated for an upgrade from v0.6.0 to v0.6.1
to address an fd leak. However, due to compatibility constraints, we
instead downgrade to v0.5, using v0.5.2 which includes a backported fix
for the same issue. So we also need to bump
selnuxfrom v1.13.0 t0v1.13.1.