ci: add checking Go version from Dockerfile #4997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 11, 2025
kolyshkin
added
backport/1.2-done
cyphar
reviewed
Nov 11, 2025
For some reason, some jobs in .github/workflows/validate.yml have "fetch-depth: 0" argument to actions/checkout, meaning "all history for all branches and tags". Obviously this is not needed here. Signed-off-by: Kir Kolyshkin <[email protected]>
This is to ensure that Go version in Dockerfile (which is used to build release binaries) is: - currently supported; - used in CI tests. Signed-off-by: Kir Kolyshkin <[email protected]>
cyphar
approved these changes
Nov 12, 2025
Member
|
This is a much simpler solution and is enough of a prod for us to go update stuff in the old branches (before we do a release) without auto-updating us to to |
This was referenced Nov 12, 2025
thaJeztah
approved these changes
Nov 12, 2025
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM seems like a sane solution for the problem, thanks!
Member
|
I think the AlmaLinux 8 CI failure is a flake -- I've opened #5003 to track this. This change to our GHA config cannot cause an unrelated error in Cirrus-CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to ensure that Go version in Dockerfile (which is used to build
release binaries) is:
Related to #4969 / alternative to #4986.