[1.1 backport] Prohibit /proc and /sys to be symlinks #3785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 3291d66 introduced a check for /proc and /sys, making sure the destination (dest) is a directory (and not e.g. a symlink). Later, a hunk from commit 0ca91f4 switched from using filepath.Join to SecureJoin for dest. As SecureJoin follows and resolves symlinks, the check whether dest is a symlink no longer works. To fix, do the check without/before using SecureJoin. Add integration tests to make sure we won't regress. Signed-off-by: Kir Kolyshkin <[email protected]> (cherry picked from commit 0d72adf) Signed-off-by: Sebastiaan van Stijn <[email protected]>
AkihiroSuda
approved these changes
Mar 25, 2023
cyphar
approved these changes
Mar 26, 2023
This was referenced Mar 27, 2023
1 task
This was referenced Nov 28, 2023
This was referenced Dec 5, 2023
This was referenced Dec 20, 2023
This was referenced Dec 30, 2023
This was referenced Feb 2, 2024
1 task
1 task
1 task
This was referenced May 11, 2024
1 task
This was referenced Jul 10, 2024
This was referenced Aug 2, 2024
1 task
This was referenced Aug 22, 2024
This was referenced Sep 24, 2024
This was referenced Oct 7, 2024
This was referenced Oct 19, 2024
1 task
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 3291d66 introduced a check for /proc and /sys, making sure the destination (dest) is a directory (and not e.g. a symlink).
Later, a hunk from commit 0ca91f4 switched from using filepath.Join to SecureJoin for dest. As SecureJoin follows and resolves symlinks, the check whether dest is a symlink no longer works.
To fix, do the check without/before using SecureJoin.
Add integration tests to make sure we won't regress.
(cherry picked from commit 0d72adf)