Skip to content

Adding oom_score_adj as a container config param #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mrunalp merged 1 commit into from
Aug 31, 2015
Merged

Adding oom_score_adj as a container config param #232

mrunalp merged 1 commit into from
Aug 31, 2015

Conversation

@vishh
Copy link
Contributor

@vishh vishh commented Aug 28, 2015

No description provided.

@vishh
Copy link
Contributor Author

vishh commented Aug 28, 2015

cc @mrunalp

mrunalp
mrunalp reviewed Aug 28, 2015
View reviewed changes
libcontainer/configs/config.go
Copy link
Contributor

@mrunalp mrunalp Aug 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think could point to https://www.kernel.org/doc/Documentation/filesystems/proc.txt instead as oom_score_adj can't be found on the lwn page.

Copy link
Contributor Author

@vishh vishh Aug 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion. Updated!

@mrunalp
Copy link
Contributor

mrunalp commented Aug 28, 2015

Also, you might want to propose this to the spec to expose it in the config :)

@vishh
Copy link
Contributor Author

vishh commented Aug 29, 2015

Yes. The next PR will be add this to the Spec.

mrunalp
mrunalp reviewed Aug 29, 2015
View reviewed changes
libcontainer/integration/exec_test.go Outdated
Copy link
Contributor

@mrunalp mrunalp Aug 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment needs to be updated.

Copy link
Contributor Author

@vishh vishh Aug 31, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Good catch :)

@wking
Copy link
Contributor

wking commented Aug 29, 2015

On Fri, Aug 28, 2015 at 05:32:38PM -0700, Vish Kannan wrote:

Yes. The next PR will be add this to the Spec.

Is a spec entry how we want to handle this? See
opencontainers/runtime-spec#115, where I suggest using a pre-start hook if
possible. I just haven't gotten around to testing if #160 will make
it possible or not (although see also my uncertainty about the hook
environment 1).

@vishh
Copy link
Contributor Author

vishh commented Aug 31, 2015

Ping @crosbymichael @LK4D4

@LK4D4
Copy link
Contributor

LK4D4 commented Aug 31, 2015

LGMT

@mrunalp
Copy link
Contributor

mrunalp commented Aug 31, 2015

LGTM

mrunalp pushed a commit that referenced this pull request Aug 31, 2015
Merge pull request #232 from vishh/oom-score-adj
5c92e5d 
Adding oom_score_adj as a container config param
@mrunalp mrunalp merged commit 5c92e5d into opencontainers:master Aug 31, 2015
@wking wking mentioned this pull request Sep 6, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status/0-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vishh @mrunalp @wking @LK4D4 @GordonTheTurtle