Skip to content

nsenter: cloned_binary: "memfd" cleanups #1984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 7, 2019
Merged

nsenter: cloned_binary: "memfd" cleanups #1984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5b775bf
nsenter: cloned_binary: detect and handle short copies
cyphar Feb 15, 2019
2429d59
nsenter: cloned_binary: expand and add pre-3.11 fallbacks
cyphar Feb 15, 2019
af9da0a
nsenter: cloned_binary: use the runc statedir for O_TMPFILE
cyphar Feb 19, 2019
16612d7
nsenter: cloned_binary: try to ro-bind /proc/self/exe before copying
cyphar Feb 26, 2019
2d4a37b
nsenter: cloned_binary: userspace copy fallback if sendfile fails
cyphar Mar 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libcontainer/container_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,6 +481,7 @@ func (c *linuxContainer) commandTemplate(p *Process, childPipe *os.File) (*exec.
cmd.ExtraFiles = append(cmd.ExtraFiles, childPipe)
cmd.Env = append(cmd.Env,
fmt.Sprintf("_LIBCONTAINER_INITPIPE=%d", stdioFdCount+len(cmd.ExtraFiles)-1),
fmt.Sprintf("_LIBCONTAINER_STATEDIR=%s", c.root),
)
// NOTE: when running a container with no PID namespace and the parent process spawning the container is
// PID1 the pdeathsig is being delivered to the container's init process by the kernel for some reason
Expand Down
Loading