Skip to content

Test PullApprove #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
caniszczyk wants to merge 1 commit into from
Closed

Test PullApprove #12

caniszczyk wants to merge 1 commit into from

Conversation

@caniszczyk
Copy link
Contributor

@caniszczyk caniszczyk commented May 26, 2016

No description provided.

@caniszczyk
Copy link
Contributor Author

caniszczyk commented May 26, 2016 •
edited
Loading

cc: @crosbymichael, can you "LGTM" this as a test?

@caniszczyk
Copy link
Contributor Author

caniszczyk commented May 26, 2016 •
edited
Loading

LGTM

Approved with PullApprove

@caniszczyk
Copy link
Contributor Author

caniszczyk commented May 26, 2016

magic... cc: @crosbymichael

@wking
Copy link
Contributor

wking commented May 26, 2016

The logic you're using 1 doesn't match the docs 2. Is it just up
to admins to keep a team in sync with the MAINTAINERS file for each
repository/project? Or is it worth updating the guide to cite the
appropriate GitHub team?

@crosbymichael
Copy link
Member

crosbymichael commented May 26, 2016

@caniszczyk nice, let me read up on this, it looks really nice and promising

@crosbymichael
Copy link
Member

crosbymichael commented May 26, 2016 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@caniszczyk
Copy link
Contributor Author

caniszczyk commented May 26, 2016

@crosbymichael looks like it worked :)

@wking wking mentioned this pull request May 26, 2016
Merged
@caniszczyk
Copy link
Contributor Author

caniszczyk commented May 31, 2016

This works, closing PR.

@caniszczyk caniszczyk closed this May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@caniszczyk @wking @crosbymichael