Add support for using a base template #35
Conversation
Signed-off-by: Mrunal Patel <[email protected]>
|
@liangchenye @rhatdan PTAL |
|
LGTM |
|
Why not make the default template use this method and ship it separate from the runc implementation. |
|
@rhatdan That would mean going elsewhere to get the first template. With this approach one can start by creating a template and then use it as the base for other templates. |
|
How do I see the default template other then reading the code? Can I easily generate the default template so I can edit it. |
|
@rhatdan Just running ocitools generate will give you the default template. |
|
Ok I guess we should document this, If you want to customize the default template, run ostree generate. Edit config.json, or run ocitools to create a config.json, which you want as your customer "template." |
|
Yeah, I will follow up with a PR with updated documentation. |
Which landed in a937f7a (Add support for using a base template, 2016-04-13, opencontainers#35) and still needs docs [1]. [1]: opencontainers#35 (comment) Signed-off-by: W. Trevor King <[email protected]>
Since a937f7a (Add support for using a base template, 2016-04-13, opencontainers#35), users have been able to supply their own templates. If --mount-cgroups is not 'no', that will lead to additional cgroup entries in the mount array (even if there was already a cgroup entry in the mount array). Instead of writing logic to find and clobber existing cgroup entries, just make the default the no-op setting. Signed-off-by: W. Trevor King <[email protected]>
Which landed in a937f7a (Add support for using a base template, 2016-04-13, opencontainers#35) and still needs docs [1]. [1]: opencontainers#35 (comment) Signed-off-by: W. Trevor King <[email protected]>
3 participants
Signed-off-by: Mrunal Patel [email protected]