Skip to content
This repository was archived by the owner on Jan 15, 2026. It is now read-only.

Conversation

@vbatts
Copy link
Member

@vbatts vbatts commented Oct 25, 2016

The image-tools has received heavy focus and contribution from Xie
Keyang (@xiekeyang) and Lie Jitang (@coolljt0725) from Huawei.

I propose add them so we can keep the progress rolling on the tools
repo!

Signed-off-by: Vincent Batts [email protected]

The image-tools has received heavy focus and contribution from Xie
Keyang and Lie Jitang from Huawei.

I propose add them so we can keep the progress rolling on the tools
repo!

Signed-off-by: Vincent Batts <[email protected]>
@jbouzane
Copy link

LGTM

2 similar comments
@philips
Copy link
Contributor

philips commented Oct 25, 2016

LGTM

@vbatts
Copy link
Member Author

vbatts commented Oct 25, 2016

LGTM

@caniszczyk
Copy link
Contributor

caniszczyk commented Oct 26, 2016

LGTM

Approved with PullApprove

1 similar comment
@philips
Copy link
Contributor

philips commented Oct 26, 2016

LGTM

Approved with PullApprove

@wking
Copy link
Contributor

wking commented Nov 2, 2016

This has passed outside of the formal “five business days” voting
window 1, although I'm not sure how seriously we take that
restriction 2. Currently the count is under the ⅔ requirement 3
by two LGTMs. @brendandburns, @jonboulle, @jstarks, @stevvooe, care
to chime in?

@coolljt0725, @xiekeyang, you should probably chime in as well with
“I'm fine becoming a maintainer” or “No thanks” or some such so folks
can tell you're not being sucked in against your will ;).

@coolljt0725
Copy link
Member

thanks all, I'm fine become a maintainer to help maintain the image-tool repo :)

@xiekeyang
Copy link
Contributor

It is my pleasure and I'm happy to become maintainer of image-tool repo. Thanks so much!

@caniszczyk caniszczyk merged commit 5589c3c into opencontainers:master Nov 8, 2016
@caniszczyk
Copy link
Contributor

I invited @xiekeyang @coolljt0725 to the team, so they should be all set once they accept :)

@vbatts
Copy link
Member Author

vbatts commented Nov 8, 2016

\o/

On Tue, Nov 8, 2016 at 11:35 AM, Chris Aniszczyk [email protected]
wrote:

I invited @xiekeyang https://github.com/xiekeyang @coolljt0725
https://github.com/coolljt0725 to the team, so they should be all set
once they accept :)


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#54 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEF6RRHxZC1DzEWaIHHmUQ7GkntDzzSks5q8KTQgaJpZM4KgD_H
.

@wking
Copy link
Contributor

wking commented Nov 8, 2016

On Tue, Nov 08, 2016 at 08:35:28AM -0800, Chris Aniszczyk wrote:

I invited @xiekeyang @coolljt0725 to the team, so they should be all
set once they accept :)

I'm not against them being accepted, but I think their addition is
still short by two LGTMs 1. Were there additional votes made
outside this PR?

@jstarks
Copy link

jstarks commented Nov 8, 2016

LGTM

Approved with PullApprove

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants