manifest.go: add the layers validation type #108
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhouhao <[email protected]>
runcom
reviewed
Feb 7, 2017
| mediatype = v1.MediaTypeImageLayerNonDistributableGzip | ||
| } | ||
|
|
||
| if err := d.validate(w, []string{mediatype}); err != nil { |
Member
There was a problem hiding this comment.
can't you just pass d.MediaType here? The rest seems redundant
Author
There was a problem hiding this comment.
Uh,Why do you think so?d.mediatype is the layer mediatype, according to the different mediatype to verify different, what is the problem?
Member
There was a problem hiding this comment.
yeah, I meant the actual media types as slice
Member
There was a problem hiding this comment.
Actually this code is wrong -- it will ignore invalid images.
I'd recommend closing this for #111.
Member
|
Closing in favor of #111 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Layer has several mediatype types, it should be completed all the mediatype.
Signed-off-by: zhouhao [email protected]