Minor tweaks to manifest for clarity #68
Conversation
manifest.md
Outdated
| # Image Manifest | ||
|
|
||
| The image manifest provides a configuration and a set of layers for a container image. | ||
| Unlike the [(Manifest List](#manifest-list), which contains information about a set of images that can span a variety of archiectures and operating systems, an image manifest provides a configuration and set of layers for a single container image for a specific architecture and operating system. |
There was a problem hiding this comment.
nit: spelling error: architectures
There was a problem hiding this comment.
fixed!
On May 6, 2016, at 11:31 AM, Brandon Philips [email protected] wrote:
In manifest.md #68 (comment):
@@ -132,14 +132,14 @@ A client will distinguish a manifest list from an image manifest based on the Co
Image Manifest
-The image manifest provides a configuration and a set of layers for a container image.
+Unlike the (Manifest List, which contains information about a set of images that can span a variety of archiectures and operating systems, an image manifest provides a configuration and set of layers for a single container image for a specific architecture and operating system.
nit: spelling error: architectures—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub https://github.com/opencontainers/image-spec/pull/68/files/9494cb085a34ec3e10a2ab5ccdf528184585c0b4#r62346141
duglin
force-pushed
the
imageTweaks
branch
3 times, most recently
from
88e45bc to
5df609c
Compare
|
lgtm |
|
@philips I did a minor tweak to this line: https://github.com/opencontainers/image-spec/pull/68/files#diff-bf8d9e5146f89ef0a8b9bf8cd1026901R152 please make sure you're still ok with it. |
|
still lgtm ;) |
manifest.md
Outdated
| This configuration item is a JSON blob that the runtime uses to set up the container. | ||
| This new schema uses a tweaked version of this configuration to allow image content-addressability on the daemon side. | ||
| The `config` property references a configuration object for a container, by digest. | ||
| The referenced configuration object is a JSON blob that the runtime uses to set up the container, see [Image JSON Description](serialization.md#image-json-description). |
Signed-off-by: Doug Davis <[email protected]>
|
|
||
| The config field references a configuration object for a container, by digest. | ||
| This configuration item is a JSON blob that the runtime uses to set up the container. | ||
| This new schema uses a tweaked version of this configuration to allow image content-addressability on the daemon side. |
There was a problem hiding this comment.
Notes on “tweaked” here, so it should be safe to remove.
|
LGTM |
The tab came in with the line in fa4c6e7 (Minor tweaks to manifest for clarity, 2016-05-06, opencontainers#68), but the rest of this file indents with spaces. Signed-off-by: W. Trevor King <[email protected]>
4 participants
Signed-off-by: Doug Davis [email protected]