oci-image-tool: initial cut by s-urbaniak · Pull Request #65 · opencontainers/image-spec

s-urbaniak · 2016-05-04T14:34:50Z

This is work in progress for the oci-image-tool, current TODOs:

s-urbaniak · 2016-05-06T11:52:54Z

gojsonschema: upstream PR xeipuuv/gojsonschema#101

philips · 2016-05-06T15:59:27Z

@@ -62,9 +62,18 @@ oci-validate-json: validate.go
 oci-validate-examples: cmd/oci-validate-examples/main.go
 	go build ./cmd/oci-validate-examples


we can replace this once you get validation done.

Not really. This tool extracts the examples from the spec for validation. Do we intend to replace the markdown extraction?

I am thinking of moving the markdown extraction to a markdown_test.go invocable via go test and not have a separate binary.

That sounds great. I am not sure why I didn't do that initially.

@stevvooe moved oci-validate-examples as a unit test, PTAL 71e5942. I did not do big refactorings, just a minimalistic 1:1 transition.

Also removed oci-validate-json since it is being replaced by oci-image-tool

s-urbaniak · 2016-05-10T15:29:08Z

@stevvooe can it be you mentioned to have manifest examples I can validate against? It'd be great to get those.

stevvooe · 2016-05-10T22:07:03Z

@s-urbaniak They are extracted directly from the specification by oci-examples-validate. We can have that tool extract them and pipe them to another tool that can validate the examples, but that tool links the specification against the schema definitions.

stevvooe · 2016-05-10T22:11:33Z

+
+// withFile opens the named file for reading and executes the given function fn if no error occured.
+// If the given function returns an error it will be returned.
+func withFile(name string, fn func(f io.Reader) error) error {


This is an odd pattern for Go. Just open the file in validatePath. withFile isn't used anywhere else.

ok, removed it, we're validating files right now only anyways.

s-urbaniak · 2016-05-11T17:46:19Z

@stevvooe OK, I was assuming you have more samples, nevermind. As mentioned above I'll try to migrate the functionality of oci-examples-validate to a Go test function. The manifest markdown links against the media type so this should be doable, right?

stevvooe · 2016-05-11T18:47:09Z

OK, I was assuming you have more samples, nevermind.

Sorry about that. I think the idea is that we would add these variations to specification to introduce them in context.

The manifest markdown links against the media type so this should be doable, right?

Yep. I think you can port this almost directly. Most of oci-examples-validate should be pulled into the presented package.

stevvooe · 2016-05-12T17:28:51Z

-func main() {
-	flag.Parse()
+func TestSpecExamples(t *testing.T) {
+	m, err := os.Open("../manifest.md")


Let's throw a TODO here to have this encompass all specification files.

liangchenye · 2016-05-13T03:41:02Z

CooI! I think it might to have this feature in https://github.com/opencontainers/ocitools,
especially for the remain tasks:

 Validate unpacked image layout on disk
 Validate compressed image
 Introduce vendored dependencies
 rethink build system

What do you think? @s-urbaniak @mrunalp @philips

stevvooe · 2016-05-13T04:59:35Z

+
+// ManifestValidator wraps a media type string identifier
+// and implements validation against a JSON schema.
+type ManifestValidator string


Small nit: these won't always be "manifests".

philips · 2016-05-19T11:18:52Z

@liangchenye right, @s-urbaniak please don't worry about validating the ondisk format. We can rely on the oci-runtime-tool for that.

philips · 2016-05-19T11:19:51Z

@s-urbaniak can we merge the tool as-is and do a follow-up PR? Essentially just add the dependencies and then we can do followup PRs for each of the remaining featrues?

s-urbaniak · 2016-05-19T14:23:12Z

@philips sure, we can mere as is! Let me squash all of this in a sec. I working on an unpacker now. What do you mean with "Essentially just add the dependencies"? Do you mean vendoring the deps?

This adds the oci-image-tool with the following capabilities: - validate manifest - validate manifest list Signed-off-by: Sergiusz Urbaniak <sur@coreos.com>

s-urbaniak · 2016-05-19T14:32:54Z

@philips squashed, ready to merge once green

philips · 2016-05-19T15:26:56Z

LGTM, can you file individual issues for the remaining things?

s-urbaniak · 2016-05-19T16:39:24Z

@philips filed #74, #75, and #76 to catch remaining TODOs and updated the description.

stevvooe · 2016-05-19T21:06:21Z

LGTM

I have no problems with merging this PR, but let's make sure to get a few more LGTMs in the future.

vbatts · 2016-05-19T21:40:08Z

This was a bigger kick off of work, but so far we've been merging with one,
sometimes two LGTMs.

On Thu, May 19, 2016, 17:30 Stephen Day notifications@github.com wrote:

LGTM

I have no problems with merging this PR, but let's make sure to get a few
more LGTMs in the future.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#65 (comment)

s-urbaniak force-pushed the validation branch from 4356a74 to 76f0a67 Compare May 4, 2016 15:15

philips added this to the v0.2.0 milestone May 5, 2016

philips added the component/oci-image-tool label May 5, 2016

s-urbaniak force-pushed the validation branch 3 times, most recently from 6cf4824 to 59fddf8 Compare May 6, 2016 15:59

philips reviewed May 6, 2016
View reviewed changes

s-urbaniak force-pushed the validation branch 8 times, most recently from 93c5e52 to 8cfb5d5 Compare May 8, 2016 15:22

stevvooe reviewed May 10, 2016
View reviewed changes

s-urbaniak force-pushed the validation branch 2 times, most recently from 471b4a8 to e768f02 Compare May 11, 2016 17:37

s-urbaniak force-pushed the validation branch from e768f02 to ff67ec5 Compare May 12, 2016 04:43

s-urbaniak force-pushed the validation branch 7 times, most recently from 4eeb12c to d287023 Compare May 12, 2016 15:38

stevvooe reviewed May 12, 2016
View reviewed changes

stevvooe reviewed May 13, 2016
View reviewed changes

oci-image-tool: initial commit

4263cf5

This adds the oci-image-tool with the following capabilities: - validate manifest - validate manifest list Signed-off-by: Sergiusz Urbaniak <sur@coreos.com>

s-urbaniak force-pushed the validation branch from ad651fa to 4263cf5 Compare May 19, 2016 14:31

jonboulle changed the title ~~[WIP] oci-image-tool DO NOT MERGE~~ oci-image-tool: initial cut May 19, 2016

jonboulle merged commit 6b5d048 into opencontainers:master May 19, 2016

wking mentioned this pull request Feb 16, 2017

*: manifest-list -> image-index #546

Merged

		@@ -62,9 +62,18 @@ oci-validate-json: validate.go
		oci-validate-examples: cmd/oci-validate-examples/main.go
		go build ./cmd/oci-validate-examples

Conversation

s-urbaniak commented May 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

s-urbaniak commented May 6, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

s-urbaniak commented May 10, 2016

Uh oh!

stevvooe commented May 10, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

s-urbaniak commented May 11, 2016

Uh oh!

stevvooe commented May 11, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

liangchenye commented May 13, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

philips commented May 19, 2016

Uh oh!

philips commented May 19, 2016

Uh oh!

s-urbaniak commented May 19, 2016

Uh oh!

s-urbaniak commented May 19, 2016

Uh oh!

philips commented May 19, 2016

Uh oh!

s-urbaniak commented May 19, 2016

Uh oh!

stevvooe commented May 19, 2016

Uh oh!

vbatts commented May 19, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

s-urbaniak commented May 4, 2016 •

edited

Loading

liangchenye commented May 13, 2016 •

edited

Loading