Skip to content

Conversation

@philips
Copy link
Contributor

@philips philips commented Sep 30, 2016

Based on rename of layer. fixes #343

Based on rename of layer. fixes opencontainers#343

Signed-off-by: Brandon Philips <[email protected]>
@philips philips force-pushed the update-img-build-diagram branch from 2dda23d to fcbf3a6 Compare September 30, 2016 20:44
@jonboulle
Copy link
Contributor

jonboulle commented Sep 30, 2016

LGTM

Approved with PullApprove

@wking
Copy link
Contributor

wking commented Sep 30, 2016

On Fri, Sep 30, 2016 at 01:42:35PM -0700, Brandon Philips wrote:

Based on rename of layer. fixes #343

Also fixes #322.

fcbf3a6 looks good to me, although I'd consider replacing the
manifest list example with a manifest (since manifest lists are
optional).

@vbatts
Copy link
Member

vbatts commented Oct 1, 2016

FAIR
LGTM

Approved with PullApprove

@vbatts vbatts merged commit 271541d into opencontainers:master Oct 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

content of manifest doesn't match the spec with image files build-diagram.png and run-diagram.png

4 participants