Skip to content

Conversation

@pmengelbert
Copy link
Contributor

  • New spec.md
  • Move 'detail' section into detail.md

To view the revised spec in complete form, see the following:
https://github.com/bloodorangeio/distribution-spec/blob/new-spec/spec.md

* New spec.md
* Move 'detail' section into detail.md

Signed-off-by: Peter Engelbert <[email protected]>
@jdolitsky jdolitsky self-requested a review August 24, 2020 18:58
Copy link
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

* Content Digests section restored to content-addressability.md
* Language clarification in detail.md
* Use Cases section restored to scenarios.md
* Scope section restored to spec.md

Signed-off-by: Peter Engelbert <[email protected]>
Signed-off-by: Peter Engelbert <[email protected]>
@pmengelbert
Copy link
Contributor Author

@mikebrow Let me know if all of your concerns have been addressed. Thanks for the review!

@vbatts
Copy link
Member

vbatts commented Aug 28, 2020

What a monumental effort. The miniupdate branch was the best way to break this rewrite up.
Doing a once-through looks essentially all there.
Thanks @jdolitsky and @pmengelbert for this work.

LGTM

Approved with PullApprove

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits.. and a couple questions.

After those it will probably be best to merge this and move to the line by line review + edits on new PRs. It's just two hard to review massive re-orgs with this tool.

@jdolitsky
Copy link
Contributor

@vbatts - we appreciate this!

@mikebrow opened #181 to link back and forth between the new spec and these other docs (content-addressibility.md etc.)

Like you said, I think it's best to get this merged then follow up with tiny PRs to amend prior to 1.0

Signed-off-by: Peter Engelbert <[email protected]>
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdolitsky
Copy link
Contributor

jdolitsky commented Aug 28, 2020

LGTM

Approved with PullApprove

@mikebrow mikebrow merged commit 2c79ed5 into opencontainers:master Aug 28, 2020
@mikebrow
Copy link
Member

thx guys! tty on monday to begin next phase :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants