Skip to content

Add reconciler object to writing better gnmi reconcilators#141

Merged
DanG100 merged 2 commits intomainfrom
reactor
Mar 19, 2025
Merged

Add reconciler object to writing better gnmi reconcilators#141
DanG100 merged 2 commits intomainfrom
reactor

Conversation

@DanG100
Copy link
Copy Markdown
Contributor

@DanG100 DanG100 commented Dec 6, 2023

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 6, 2023

Pull Request Test Coverage Report for Build 7120870841

  • 52 of 127 (40.94%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.2%) to 80.238%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ygnmi/unmarshal.go 4 9 44.44%
ygnmi/ygnmi.go 42 112 37.5%
Totals Coverage Status
Change from base Build 7120174837: -2.2%
Covered Lines: 2026
Relevant Lines: 2525

💛 - Coveralls

@DanG100 DanG100 changed the title idea for leaf reactors Add reconciler object to writing better gnmi reconcilators Mar 13, 2025
@DanG100 DanG100 marked this pull request as ready for review March 13, 2025 22:02
@DanG100 DanG100 requested a review from robshakir March 13, 2025 22:02
@DanG100
Copy link
Copy Markdown
Contributor Author

DanG100 commented Mar 13, 2025

I plan on using the changes to yang in a follow up PR

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 13, 2025

Pull Request Test Coverage Report for Build 13934384434

Details

  • 190 of 2939 (6.46%) changed or added relevant lines in 10 files are covered.
  • 2832 unchanged lines in 26 files lost coverage.
  • Overall coverage decreased (-10.4%) to 7.275%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ygnmi/path_types.go 61 64 95.31%
ygnmi/ygnmi.go 129 171 75.44%
exampleoc/structs-0.go 0 125 0.0%
internal/exampleocconfig/structs-0.go 0 125 0.0%
internal/exampleocunordered/structs-0.go 0 125 0.0%
internal/uexampleoc/structs-0.go 0 247 0.0%
internal/exampleocunordered/withlistval/withlistval-0.go 0 392 0.0%
exampleoc/a/a-0.go 0 500 0.0%
internal/exampleocconfig/a/a-0.go 0 500 0.0%
internal/uexampleoc/a/a-0.go 0 690 0.0%
Files with Coverage Reduction New Missed Lines %
exampleoc/enum.go 1 0.0%
internal/exampleocconfig/enum.go 1 0.0%
internal/uexampleoc/enum.go 3 0.0%
internal/exampleocunordered/structs-0.go 9 0.0%
exampleoc/enum_map.go 10 0.0%
internal/exampleocconfig/enum_map.go 10 0.0%
internal/exampleocunordered/enum_map.go 10 0.0%
internal/uexampleoc/enum_map.go 10 0.0%
internal/logutil/logutil.go 12 0.0%
internal/exampleocunordered/exampleocunorderedpath/exampleocunorderedpath.go 13 0.0%
Totals Coverage Status
Change from base Build 13063373234: -10.4%
Covered Lines: 2216
Relevant Lines: 30461

💛 - Coveralls

@DanG100 DanG100 merged commit 188ce0d into main Mar 19, 2025
9 checks passed
@DanG100 DanG100 deleted the reactor branch March 19, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants