Add hidden -typedef_enum_with_defmod flag#119
Merged
Conversation
Pull Request Test Coverage Report for Build 6803318205
💛 - Coveralls |
wenovus
changed the title
Contributor
|
might also be worth considering ygnmi 1.0 (after ygot) |
DanG100
approved these changes
Nov 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change whose intention is to enforce that
-typedef_enum_with_defmod=truefor all new generated ygnmi code.There are many existing ygot-generated code that has
-typedef_enum_with_defmod=truebecause it is planned for deprecation in ygot@v1: openconfig/ygot#404, and therefore any new generated code should use it as the standard.Keeping it as a hidden flag to allow existing users to continue generating without issues.