Merged
Conversation
aaronbee
reviewed
Mar 1, 2021
|
|
||
| // This is a compile-time assertion to ensure that this generated file | ||
| // is compatible with the grpc package it is being compiled against. | ||
| const _ = grpc.SupportPackageIsVersion6 |
There was a problem hiding this comment.
Not sure if this was intentional or not, but this is downgrade of the method of compiling the proto code to Go. The new method uses a separate protoc plugin for generating the grpc service: google.golang.org/grpc/cmd/protoc-gen-go-grpc. You should end up with a separate _grpc.pb.go file.
Contributor
Author
There was a problem hiding this comment.
thanks for catching this. it was generated by compile_proto.sh, which seems to be using --go_out=plugins=grpc,.
will update the script shortly.
|
Hi, how can i install gnoi on linux machine? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tunnel_grpc.pb.go was merged into the tunnelpb.go file.