[gribi-compliance-get] Add caching for HasResults to improve performance on large result sets.#84
Conversation
* (M) compliance/compliance.go
- Add a compliance test for implicit replace of IPv4, NHG, and NH
entries when ADD is called multiple times.
- Add a compliance test for replace failing for missing entries.
* (M) chk/chk_test.go - Unit testing for HasResults cache.
robshakir
changed the title
This was referenced Oct 13, 2021
sthesayi
approved these changes
Oct 13, 2021
* Add base unit tests for Get.
* (M) compliance/compliance.go
* (A) compliance/get.go
* (A) compliance/get_test.go
- Add initial testing for Get, validating that Get can be executed
against the target.
- Add benchmarking test for Get.
- Rename doOps to doModifyOps to make this clearer.
* Merge fixed unit tests.
* [gribi-compliance-get] Add GetResponse check helper function. (#86)
* Add GetResponse check helper function.
* (M) chk/chk.go
* (M) chk/chk_test.go
- Add new check that determines whether a particular GetResponse has
a set of entries within it.
* (M) fluent/fluent.go
* (M) fluent/fluent_test.go
- Make GRIBIEntry's EntryProto method public such that it can be used
within the chk library.
* [gribi-compliance-get] Implement tests for Get with checks. (#87)
* Implement tests for Get with checks.
* (M) compliance/compliance.go
* (M) compliance/get.go
- Add tests for Get for NH, NHG, IPv4 and a chain of entries for
IPv4 using the Get RPC.
* Add FIB ACK mode for Get tests. (#88)
* Fix typo.
* (M) compliance/get.go
- Update doc comment typo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: add compliance tests for Get.
Stacked PR Chain: gribi-compliance-get