Skip to content

Add compliance tests for IPv4 entries, fix server defect.#65

Merged
robshakir merged 5 commits intomainfrom
compl00
Aug 12, 2021
Merged

Add compliance tests for IPv4 entries, fix server defect.#65
robshakir merged 5 commits intomainfrom
compl00

Conversation

@robshakir
Copy link
Copy Markdown
Member

  * (M) client/client.go
    - Improve logging.
  * (M) compliance/compliance.go
    - Add test for adding IPv4 entry in a single ModifyRequest,
     and within separate requests.
  * (M) fluent/fluent.go
    - Add support for WithIPAddress to builder.
  * (M) gnmit/gnmit.go
    - Minor refactor to use a new GNMIServer container - no-op
    change for adding gNMI Set support.
  * (M) rib/rib.go
    - Improve logging.
  * (M) server/server.go
  * (M) server/server_test.go
    - Resolve a defect whereby the server called modifyEntry within
      a goroutine per operation within a ModifyRequest. In the case
      where a single ModifyRequest made multiple entries resolvable,
      then an entry could be duplicate ACK'd, by all the entries that
      made it resolvable. Whilst the RIB is safe to modify in this
      manner, the pending queue could result in this occurring - the
      duplicate install is a NOOP, but the duplicate ACK violated the
      API contract. Initially, resolve this issue by serially processing
      modify requests - added a TODO to cover a less naive solution.

  * (M) client/client.go
    - Improve logging.
  * (M) compliance/compliance.go
    - Add test for adding IPv4 entry in a single ModifyRequest,
     and within separate requests.
  * (M) fluent/fluent.go
    - Add support for WithIPAddress to builder.
  * (M) gnmit/gnmit.go
    - Minor refactor to use a new GNMIServer container - no-op
    change for adding gNMI Set support.
  * (M) rib/rib.go
    - Improve logging.
  * (M) server/server.go
  * (M) server/server_test.go
    - Resolve a defect whereby the server called modifyEntry within
      a goroutine per operation within a ModifyRequest. In the case
      where a single ModifyRequest made multiple entries resolvable,
      then an entry could be duplicate ACK'd, by all the entries that
      made it resolvable. Whilst the RIB is safe to modify in this
      manner, the pending queue could result in this occurring - the
      duplicate install is a NOOP, but the duplicate ACK violated the
      API contract. Initially, resolve this issue by serially processing
      modify requests - added a TODO to cover a less naive solution.
@robshakir robshakir requested a review from liulk July 15, 2021 22:32
@robshakir
Copy link
Copy Markdown
Member Author

@liulk - PTAL, I merged your changes to take the stub as an argument here.

  * (M) client/client.go
    - Improve debugging output of an operation result.
  * (M) compliance/compliance.go
    - Add tests for deleting IPv4 entries, NHGs, NHs - both positive
      and negative tests.
  * (M) fluent/fluent.go
    - Add ability to reference a NHG NI from an IPv4Entry.
  * (M) go.sum
    - Tidy up go modules.
@robshakir robshakir merged commit 63aae1a into main Aug 12, 2021
@robshakir robshakir deleted the compl00 branch August 12, 2021 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants