Conversation
Member
robshakir
commented
Jul 1, 2021
* (M) client/client.go
- Improve logging.
* (M) compliance/compliance.go
- Add test for adding IPv4 entry in a single ModifyRequest,
and within separate requests.
* (M) fluent/fluent.go
- Add support for WithIPAddress to builder.
* (M) gnmit/gnmit.go
- Minor refactor to use a new GNMIServer container - no-op
change for adding gNMI Set support.
* (M) rib/rib.go
- Improve logging.
* (M) server/server.go
* (M) server/server_test.go
- Resolve a defect whereby the server called modifyEntry within
a goroutine per operation within a ModifyRequest. In the case
where a single ModifyRequest made multiple entries resolvable,
then an entry could be duplicate ACK'd, by all the entries that
made it resolvable. Whilst the RIB is safe to modify in this
manner, the pending queue could result in this occurring - the
duplicate install is a NOOP, but the duplicate ACK violated the
API contract. Initially, resolve this issue by serially processing
modify requests - added a TODO to cover a less naive solution.
Member
Author
|
@liulk - PTAL, I merged your changes to take the stub as an argument here. |
liulk
approved these changes
Aug 11, 2021
* (M) client/client.go
- Improve debugging output of an operation result.
* (M) compliance/compliance.go
- Add tests for deleting IPv4 entries, NHGs, NHs - both positive
and negative tests.
* (M) fluent/fluent.go
- Add ability to reference a NHG NI from an IPv4Entry.
* (M) go.sum
- Tidy up go modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.