Add a hook that is called for entries after install.#62
Merged
Conversation
Member
robshakir
commented
Jun 23, 2021
robshakir
commented
* (D) a
- Remove erroneous file.
* (A) afthelper/afthelper.go
* (A) afthelper/afthelper_test.go
- Add a helper function to take a RIB and determine the set of
IP address next-hops from the AFT model. This allows us to
take an input gRIBI entry and determine what next-hop IPs
it uses, which then can be resolved to connected interfaces.
* (M) rib/rib.go
* (M) rib/rib_test.go
- add new ResolvedEntryFn that is called after AddEntry with
full context of the set of RIBs.
- rename existing each -> PostChangeHook.
* (M) server/server.go
- rename post change hook.
* (M) rib/rib_test.go
- Add test of using afthelper to resolve the entries that are
to be installed.
sthesayi
approved these changes
Jul 1, 2021
* (M) afthelper/afthelper.go
- Add JSON marshalling for summary next-hops.
* (M) sysrib/sysrib.go
* (M) sysrib/sysrib_test.go
- Add support for recursing onto non-connected next-hops
to egress interface.
* (M) compliance/compliance.go
- Make the compliance test case actually resolve an IPv4
prefix to an egress interface
* (M) device/device.go
* (M) device/device_test.go
- Connect the gRIBI server to sysRIB so that entries that are
installed are then installed into the sysRIB when they are
resolved.
* (M) fluent/fluent.go
- Add support
* (M) server/server.go
- Rename hooks to be more intuitive.
* (M) afthelper/afthelper_test.go
- Add missing copyright notice to afthelper_test.go
* (M) rib/rib_test.go
- Remove panic() from test call.
* (M) sysrib/sysrib.go
- Ensure that we have a lock on the RIB now concurrent access
is possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.