Skip to content

Add support for Delete of entries.#55

Merged
robshakir merged 5 commits intomainfrom
delete-replace-0
Jun 23, 2021
Merged

Add support for Delete of entries.#55
robshakir merged 5 commits intomainfrom
delete-replace-0

Conversation

@robshakir
Copy link
Copy Markdown
Member

 * (M) fluent/fluent.go
 * (M) fluent/fluent_test.go
   - Add Status() to retrieve client status in tests - this allows for send and
     receive errors to be checked.
   - Add DeleteEntry() function to submit a set of entries to be deleted by the
     server, and corresponding ReplaceEntry() function.
 * (M) rib/rib.go
 * (M) rib/rib_test.go
   - Add top-level DeleteEntry function that can take an operation from the caller.
   - Fix DeleteIPv4 to not check content as per design discussion.
   - Add DeleteNextHopGroup and DeleteNextHop.
   - Test coverage for individual DeleteXXX and the overall DeleteEntry.
   - Improve test coverage by injecting check functions that inject errors and
     programming failures.
 * (M) server/server.go
 * (M) server/server_test.go
   - Add support for delete and replace in doModify by generalising addEntry.
     This ensures that we do not have multiple places in the implementation
     that need to be aware of each operation.

  - testing for deleting ipv4/nhg/nh
  - implementation for replace of all
@robshakir robshakir added this to the dataplane-prodder milestone Jun 22, 2021
@robshakir robshakir requested a review from sthesayi June 22, 2021 15:06
@robshakir
Copy link
Copy Markdown
Member Author

Thanks for the review!

@robshakir robshakir merged commit c915ebc into main Jun 23, 2021
@robshakir robshakir deleted the delete-replace-0 branch June 23, 2021 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants