Skip to content

Add GetRIB method for an individual RIBHolder.#42

Merged
robshakir merged 4 commits intomainfrom
get0
Jun 21, 2021
Merged

Add GetRIB method for an individual RIBHolder.#42
robshakir merged 4 commits intomainfrom
get0

Conversation

@robshakir
Copy link
Copy Markdown
Member

Add initial support for the Get RPC to RIBHolder per #34.

commit 999142eeb8034737023c572bed3070fb6e1de4c3
Author: Rob Shakir <robjs@google.com>
Date:   Sat Jun 19 16:48:06 2021 -0700

    Remove unused protobuf functions.
    
      * (M) rib/rib.go
        - Remove proto functions.

commit c3d405dc9ff8e0adc448b2d9b0f9e96a89e7a287
Author: Rob Shakir <robjs@google.com>
Date:   Sat Jun 19 16:45:02 2021 -0700

    Add GetRIB function to RIBHolder.
    
      * (M) rib/rib.go
      * (M) rib/rib_test.go
        - Add GetRIB function to RIBHolder that iterates through the
          contents of the RIB and returns the entries as gRIBI GetResponse
          messages via the specified channel.

  * (M) rib/rib.go
  * (M) rib/rib_test.go
    - Add GetRIB function to RIBHolder that iterates through the
      contents of the RIB and returns the entries as gRIBI GetResponse
      messages via the specified channel.
  * (M) rib/rib.go
    - Remove proto functions.
@robshakir robshakir requested a review from sthesayi June 20, 2021 15:44
return nil
}

func (r *RIBHolder) GetRIB(msgCh chan *spb.GetResponse, stopCh chan struct{}) error {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing method comment.

@robshakir robshakir merged commit a831aea into main Jun 21, 2021
@robshakir robshakir deleted the get0 branch June 21, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants