Add test coverage for connections to device.#126
Merged
Conversation
* (M) device/device.go
* (M) device/device_test.go
- add a check that gNMI updates are handled properly by the device.
* (M) gnmit/gnmit.go
* (M) gnmit/gnmit_test.go
- Ensure that TLS credentials are handled properly.
- return errors when cache update is not correctly handled.
xw-g
reviewed
Mar 14, 2022
bstoll
approved these changes
Mar 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bstoll PTAL.
You can verify that this works using:
To validate gNMI - using the listen address returned for gNMI, and
gnmi_clifrom github.com/openconfig/gnmi:To validate gRIBI - using the listen address returned for gRIBI:
After this test, re-running the gNMI validation should show the AFT populated (running it during will show it being added, with
-qt srather than-qt o):PTAL and let me know if you have issues here. There's one potential fix in here, so please test on this branch. This also adds integration tests.