Remove support for empty NI name per gRIBI spec.#122
Merged
Conversation
* (M) compliance/compliance.go
- Update tests that do not explicitly specify a network instance
name for the default network instance name to include one.
* (M) server/server.go
* (M) server/server_test.go
- Update reference server implementation to remove the handling
of an empty network instance name.
xw-g
reviewed
Mar 2, 2022
Member
Author
|
Thanks! Somehow I missed the latter one. Let me fix that! On the first one, that is just creating the default RIB on the server (rather than the expectation in the API) since we do not ingest a configuration on the reference server to tell us what the name should be. |
* (M) server/server.go
- Remove rewrite of "" to default network instance name.
Member
Author
|
Thanks - removed the rewrite in |
xw-g
approved these changes
Mar 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See openconfig/gribi#34 for details of this change.