Add unit testing for HasRecvClientErrorWithStatus.#105
Merged
Conversation
Member
robshakir
commented
Jan 12, 2022
robshakir
commented
* (M) chk/chk.go
- when chk.AllowUnimplemented() is specified, details of the error
(which hasn't been explcitly implemented) are still checked -
change the implementation to explicitly not require details to
match in these cases.
* (M) chk/chk_test.go
- Add unit testing for HasRecvErrorWithStatus.
* (M) chk/chk.go
* (M) chk/chk_test.go
- Fix implementation of IgnoreDetails to ensure that it allows
details received from the server to be ignored rather than
solely from the client.
- Add unit test.
Member
Author
|
@deep-gajjar5 @sthesayi Could you PTAL/approve here please? |
sthesayi
approved these changes
Jan 14, 2022
deep-gajjar5
approved these changes
Jan 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.