Skip to content

Add basic Reusable Go workflow#1

Merged
wenovus merged 3 commits intomainfrom
basic_go_workflow
Aug 8, 2023
Merged

Add basic Reusable Go workflow#1
wenovus merged 3 commits intomainfrom
basic_go_workflow

Conversation

@wenovus
Copy link
Copy Markdown
Contributor

@wenovus wenovus commented Aug 7, 2023

Passes for the following repos:

For gribigo I'm seeing some non-deterministic failures, but the CI script is running fine:

Next steps:

  • Add golangci-lint, which will be declared as a different reusable workflow.
  • compiling protocol buffers in order to run for gribi.

@wenovus
Copy link
Copy Markdown
Contributor Author

wenovus commented Aug 8, 2023

@robshakir request to add @bstoll to the @openconfig/ci-maintainers team

@wenovus wenovus requested a review from bstoll August 8, 2023 16:42
@bstoll
Copy link
Copy Markdown
Contributor

bstoll commented Aug 8, 2023

Any thoughts on also including github.com/mgechev/revive ?

https://github.com/openconfig/featureprofiles/blob/5276cad8bf87e1fdc6e1872bf8b9647898d009bc/.github/workflows/pull_request.yml#L90-L93

We added this in featureprofiles to catch more Go readability issues.

@wenovus
Copy link
Copy Markdown
Contributor Author

wenovus commented Aug 8, 2023

Any thoughts on also including github.com/mgechev/revive ?

https://github.com/openconfig/featureprofiles/blob/5276cad8bf87e1fdc6e1872bf8b9647898d009bc/.github/workflows/pull_request.yml#L90-L93

We added this in featureprofiles to catch more Go readability issues.

I'll add it in the next PR.

@wenovus wenovus merged commit f94615f into main Aug 8, 2023
@wenovus wenovus deleted the basic_go_workflow branch August 8, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants