Skip to content

Change default value of ACL Counter attribute #2247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shaigai21 wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Change default value of ACL Counter attribute #2247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion inc/saiacl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3436,7 +3436,7 @@ typedef enum _sai_acl_counter_attr_t
*
* @type bool
* @flags CREATE_ONLY
* @default false
* @default true
Copy link
Copy Markdown

@ibarnea ibarnea Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes more sense to change default to true on packet count (or both), and fix the comment.
What does this comment mean? "Only Byte count used which is set to disable". I think it should be changed to "Only Byte count used". Meaning it is illegal to create a counter which counts only bytes and not packets.

Copy link
Copy Markdown
Author

@Shaigai21 Shaigai21 Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should read the whole paragraph. "By default, Byte Counter would be created and following use of the below attributes would result in an error." So the cases below are ones that lead to an error: disabling byte count and not enabling packet count means that counter does not count anything. Only configurations with at least one enabled counter are allowed, but the Byte Counter is enabled by default.

Copy link
Copy Markdown

@ibarnea ibarnea Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Understood. I agree that your change aligns with the comment

*/
SAI_ACL_COUNTER_ATTR_ENABLE_BYTE_COUNT,

Expand Down