Skip to content

Link Layer Retry support in SAI.#2225

Merged
tjchadaga merged 1 commit intoopencomputeproject:masterfrom
rck-innovium:rck_llr_ocp
Jan 8, 2026
Merged

Link Layer Retry support in SAI.#2225
tjchadaga merged 1 commit intoopencomputeproject:masterfrom
rck-innovium:rck_llr_ocp

Conversation

@rck-innovium
Copy link
Copy Markdown
Contributor

@rck-innovium rck-innovium commented Nov 5, 2025

Link Layer Retry support in SAI based on Ultra Ethernet Consortium spec 1.0 Chapter 5.1.

Note:

  • PRs proposed by UEC, if reviewed by non UEC members must sign the waiver agreement form between OCP and UEC. This signed form will be checked in along with PR for audit purposes.

Please refer: #2226

@tjchadaga tjchadaga added the reviewed PR is discussed in SAI Meeting label Nov 6, 2025
@tjchadaga
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@rck-innovium
Copy link
Copy Markdown
Contributor Author

@JaiOCP @j-bos please review.

Copy link
Copy Markdown
Contributor

@JaiOCP JaiOCP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rck-innovium Please check in the Waiver Form for non UEC Members who would like to review the PR.
Each reviewer if not a UEC member, MUST sign the waiver form. Signed waiver form will be committed as part of the PR commit process for audit trail purposes.

@tjchadaga
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Contributor

@JaiOCP JaiOCP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Copy Markdown
Contributor

@j-bos j-bos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but one whitespace item to address (may affect metadata build)

inc/saiport.h Outdated
SAI_LLR_FRAME_ACTION_BLOCK,

/** Frames are treated as regular packets and are transmitted. */
SAI_LLR_FRAME_ACTION_BEST_EFFORT,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra comma

@tjchadaga
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@kcudnik
Copy link
Copy Markdown
Collaborator

kcudnik commented Jan 4, 2026

ERROR: invalid type '' for SAI_PORT_ATTR_LLR_MODE_LOCAL
ERROR: flags are not defined for SAI_PORT_ATTR_LLR_MODE_LOCAL

@tjchadaga
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@tjchadaga tjchadaga merged commit 5690c98 into opencomputeproject:master Jan 8, 2026
3 checks passed
vivekrnv added a commit to vivekrnv/SAI that referenced this pull request Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewed PR is discussed in SAI Meeting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants