Added saithrift support to return sai_object_id for a given system_port_id and read VOQ counters for system port#1931
Merged
kcudnik merged 2 commits intoopencomputeproject:masterfrom Dec 6, 2023
saksarav-nokia:saksarav-voq-counters
Merged
Added saithrift support to return sai_object_id for a given system_port_id and read VOQ counters for system port#1931kcudnik merged 2 commits intoopencomputeproject:masterfrom saksarav-nokia:saksarav-voq-counters
kcudnik merged 2 commits intoopencomputeproject:masterfrom
saksarav-nokia:saksarav-voq-counters
Conversation
…rt_id and read VOQ counters for system port Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
Contributor
Author
|
@vmittal-msft , this is the saithrift PR for VOQ counters. |
kcudnik
reviewed
Dec 1, 2023
|
|
||
| extern sai_object_id_t gSwitchId; | ||
|
|
||
|
|
Contributor
Author
There was a problem hiding this comment.
Removed the extra blank line
Collaborator
|
should we develop saithrift v2 instead of saithrift ? |
Contributor
Author
I see only .h file in saithriftv2 and the source code is only in saithrift for all the existing functions. |
vmittal-msft
reviewed
Dec 1, 2023
| } | ||
| // Returns sai_object_id for a system_port_id | ||
| sai_thrift_object_id_t sai_thrift_get_sys_port_obj_id_by_port_id(const int32_t sys_port_id) { | ||
| printf("sai_thrift_get_sys_port_id_by_port_id\n"); |
Contributor
There was a problem hiding this comment.
Can we use SAI_THRIFT log instead of printf ?
|
|
||
| status = sai_api_query(SAI_API_SWITCH, (void **) &switch_api); | ||
| if (status != SAI_STATUS_SUCCESS) { | ||
| printf("sai_api_query failed!!!\n"); |
Contributor
There was a problem hiding this comment.
Can we use SAI_THRIFT log instead of printf ?
| attr.id = SAI_SWITCH_ATTR_TYPE; | ||
| status = switch_api->get_switch_attribute(gSwitchId, 1, &attr); | ||
| if (status != SAI_STATUS_SUCCESS) { | ||
| printf("get_switch_attribute failed!!!\n"); |
Contributor
There was a problem hiding this comment.
Can we use SAI_THRIFT log instead of printf ?
| return SAI_NULL_OBJECT_ID; | ||
| } | ||
| void sai_thrift_get_system_port_attribute(sai_thrift_attribute_list_t& thrift_attr_list, const sai_thrift_object_id_t sys_port_oid) { | ||
| printf("sai_thrift_get_system_port_attribute for 0x%lx\n", sys_port_oid); |
Contributor
There was a problem hiding this comment.
Can we use SAI_THRIFT log instead of printf ?
Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
kcudnik
approved these changes
Dec 5, 2023
vmittal-msft
approved these changes
Dec 6, 2023
Contributor
This was referenced Dec 12, 2023
saksarav-nokia
added a commit
to saksarav-nokia/SAI
that referenced
this pull request
Dec 22, 2023
…rt_id and read VOQ counters for system port (opencomputeproject#1931) For VOQ Chassis, the following two API's are added Reads all the system ports in the switch from SAI and returns the sai_object_id of the system port requested by the sonic-mgmt. Takes the sai_object_id of the system port and returns all the VOQs for that system port. Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
rlhui
pushed a commit
that referenced
this pull request
Jan 2, 2024
…rt_id and read VOQ counters for system port (#1931) For VOQ Chassis, the following two API's are added Reads all the system ports in the switch from SAI and returns the sai_object_id of the system port requested by the sonic-mgmt. Takes the sai_object_id of the system port and returns all the VOQs for that system port.
kcudnik
pushed a commit
that referenced
this pull request
Jan 3, 2024
…rt_id and read VOQ counters for system port (#1931) (#1937) For VOQ Chassis, the following two API's are added Reads all the system ports in the switch from SAI and returns the sai_object_id of the system port requested by the sonic-mgmt. Takes the sai_object_id of the system port and returns all the VOQs for that system port. Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
Collaborator
|
@saksarav-nokia which exact test this is needed? Thanks. |
Contributor
Author
|
@rlhui , We have enhanced sonic-mgmt Qos LossyQTest to verify the Voq counters. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For VOQ Chassis, the following two API's are added