Skip to content

[Cherry-pick][SAI-PTF]cherry pick fixed from master(#1651)(#1656)#1662

Merged
richardyu-ms merged 2 commits intoopencomputeproject:v1.11from
richardyu-ms:cherry-pick-fix-v1.11
Nov 20, 2022
Merged

[Cherry-pick][SAI-PTF]cherry pick fixed from master(#1651)(#1656)#1662
richardyu-ms merged 2 commits intoopencomputeproject:v1.11from
richardyu-ms:cherry-pick-fix-v1.11

Conversation

richardyu-ms and others added 2 commits November 20, 2022 05:07
* add invocation logger

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>

* reformat code

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
Co-authored-by: richardyu <richardyu@contoso.com>
* [SAI-PTF]add conditional import for unit test

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>

* [SAI-PTF]add conditional import for unit test

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
@richardyu-ms richardyu-ms merged commit 949a71f into opencomputeproject:v1.11 Nov 20, 2022
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Nov 20, 2022

This pull request introduces 9 alerts when merging e439a2f into bb50de8 - view on LGTM.com

new alerts:

  • 5 for Unused import
  • 3 for Unused local variable
  • 1 for First parameter of a method is not named 'self'

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@richardyu-ms richardyu-ms deleted the cherry-pick-fix-v1.11 branch January 1, 2023 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant