Skip to content

[SAI-PTF] add invocation logger#1650

Merged
richardyu-ms merged 2 commits intoopencomputeproject:v1.7from
richardyu-ms:add_logger
Nov 16, 2022
Merged

[SAI-PTF] add invocation logger#1650
richardyu-ms merged 2 commits intoopencomputeproject:v1.7from
richardyu-ms:add_logger

Conversation

@richardyu-ms
Copy link
Copy Markdown
Collaborator

Add invocation logger for all the method in sai_adapter.
Add test cases for check the template function

the log looks like

11/14/2022 01:10:07 PM - test/sai_test/sai_sanity_test.py:SaiSanityTest - sai_adapter.py - INFO - sai_adapter_invoke func:[sai_thrift_create_switch] args: [{'client': <sai_thrift.sai_rpc.Client object at 0x7f3beebb27f0>, 'init_switch': True, 'src_mac_address': '00:77:66:55:44:00'}]

Test done:
unit test
dut test

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Nov 14, 2022

This pull request introduces 3 alerts when merging 4f34c9a into a87db93 - view on LGTM.com

new alerts:

  • 2 for Use of 'global' at module level
  • 1 for First parameter of a method is not named 'self'

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Nov 14, 2022

This pull request introduces 3 alerts when merging 24effcf into a87db93 - view on LGTM.com

new alerts:

  • 2 for Use of 'global' at module level
  • 1 for First parameter of a method is not named 'self'

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Nov 15, 2022

This pull request introduces 7 alerts when merging 762a8bd into 06b7089 - view on LGTM.com

new alerts:

  • 4 for Unused import
  • 2 for Unused local variable
  • 1 for First parameter of a method is not named 'self'

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants