Add hostif trap for NTP#1453
Add hostif trap for NTP#1453rlhui merged 2 commits intoopencomputeproject:masterfrom vivekmoorthy:master
Conversation
|
@kcudnik @rck-innovium @JaiOCP @kperumalbfn Mind reviewing this PR? It's similar to #1436 |
https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xhtml?search=ntp Signed-off-by: Vivek Ramamoorthy <[email protected]>
|
@rck-innovium Could you help with this review? |
|
@kcudnik I see the PR is waiting on "LGTM analysis: Python" |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
not sure why this hanged on python, no changes are here made |
|
if this retrigger will not help, please add force empty commit to this branch this will retrigger all pipelines |
|
i'm not able to retrigger python from github page @vivekmoorthy, please add empty commit here to retrigger |
Signed-off-by: Vivek Ramamoorthy <[email protected]>
|
Thanks. retriggered and now the checks have passed. |
|
@rck-innovium @JaiOCP @kperumalbfn could you provide your approvals again due to retrigger. |
|
@kcudnik If approvals look ok, would you be able to help with merging this PR? |
|
was this discussed and approved on latest SAI community meeting? |
This PR was discussed 2 weeks back in SAI meeting and the decision was to split the Traps to NTPCLIENT and NTPSERVER. @lguohan for visibility. |
Add IANA-reserved port for NTP:
https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xhtml?search=ntp