Add attribute for number of available SAs per SC#1420
Merged
rlhui merged 1 commit intoopencomputeproject:masterfrom Feb 28, 2022
Merged
Add attribute for number of available SAs per SC#1420rlhui merged 1 commit intoopencomputeproject:masterfrom
rlhui merged 1 commit intoopencomputeproject:masterfrom
Conversation
judyjoseph
approved these changes
Feb 26, 2022
SarathBug
approved these changes
Feb 26, 2022
rlhui
approved these changes
Feb 28, 2022
Collaborator
|
@skbarista - build failed. |
skbarista
force-pushed
the
onebitan
branch
2 times, most recently
from
f2ff8e7 to
8138e1c
Compare
Signed-off-by: Sambath Kumar Balasubramanian <sambath@arista.com>
Contributor
Author
|
@rlhui I squashed the commits and build looks fine now. |
Contributor
|
@skbarista Sarath, can you respond to my query so that I can close the review |
Contributor
Author
|
@JaiOCP was there a question for me? I did not see a question in the pr conversations. |
Contributor
@skbarista Hi Sambath, Sorry yes it was a question for you. I have left review comments. .....snippet... Contributor |
Contributor
Author
|
@JaiOCP I think when I squashed the commit, the comment got lost. Right now the only values for number of secure associations are 2 and 4. |
Contributor
Thanks. |
JaiOCP
reviewed
Feb 28, 2022
| SAI_MACSEC_MAX_SECURE_ASSOCIATIONS_PER_SC_TWO, | ||
| SAI_MACSEC_MAX_SECURE_ASSOCIATIONS_PER_SC_FOUR, | ||
| } sai_macsec_max_secure_associations_per_sc_t; | ||
|
|
Contributor
There was a problem hiding this comment.
Are secure association always power of 2?
JaiOCP
approved these changes
Feb 28, 2022
rlhui
approved these changes
Feb 28, 2022
Pterosaur
pushed a commit
to sonic-net/sonic-swss
that referenced
this pull request
May 18, 2022
What I did Taught MacsecOrch to use the SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC attribute added in opencomputeproject/SAI#1420 Why I did it To support SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC in MacsecOrch. How I verified it The changes have no impact until SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC is supported by the platform. Details Cache the the result of SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC in MACsecObject.m_max_sa_per_sc. Set STATE_DB MACSEC_PORT_TABLE's max_sa_per_sc to the value cached in MACsecObject.m_max_sa_per_sc in createMACsecPort. Signed-off-by: Nathan Wolfe <nwolfe@arista.com>
preetham-singh
pushed a commit
to preetham-singh/sonic-swss
that referenced
this pull request
Aug 6, 2022
What I did Taught MacsecOrch to use the SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC attribute added in opencomputeproject/SAI#1420 Why I did it To support SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC in MacsecOrch. How I verified it The changes have no impact until SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC is supported by the platform. Details Cache the the result of SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC in MACsecObject.m_max_sa_per_sc. Set STATE_DB MACSEC_PORT_TABLE's max_sa_per_sc to the value cached in MACsecObject.m_max_sa_per_sc in createMACsecPort. Signed-off-by: Nathan Wolfe <nwolfe@arista.com>
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
What I did Taught MacsecOrch to use the SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC attribute added in opencomputeproject/SAI#1420 Why I did it To support SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC in MacsecOrch. How I verified it The changes have no impact until SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC is supported by the platform. Details Cache the the result of SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC in MACsecObject.m_max_sa_per_sc. Set STATE_DB MACSEC_PORT_TABLE's max_sa_per_sc to the value cached in MACsecObject.m_max_sa_per_sc in createMACsecPort. Signed-off-by: Nathan Wolfe <nwolfe@arista.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add attribute for number of available SAs per SC