Unset SAI_PORT_ATTR_HW_LANE_LIST as key#1278
Unset SAI_PORT_ATTR_HW_LANE_LIST as key#1278byu343 wants to merge 1 commit intoopencomputeproject:masterfrom
Conversation
The reason is that we are using one syncd process to support multiple phy chips and for the ports from different phys, they may have the same value on SAI_PORT_ATTR_HW_LANE_LIST. Signed-off-by: Boyang Yu <[email protected]>
|
i do not understand this, they are different switches, the key should only matter on one switch. where do you see the issue? |
| * @brief Hardware Lane list | ||
| * | ||
| * @type sai_u32_list_t | ||
| * @flags MANDATORY_ON_CREATE | CREATE_ONLY | KEY |
There was a problem hiding this comment.
hw lane list identifies uniquely ports on a single switch, it must be a KEY, please revert
There was a problem hiding this comment.
is the error you getting from metadata in OA or syncd? can you paste error? is the scenario you are facing is that you have 2 SAI switches, one of the ports on 1st switch and one of the ports on 2nd switch have the same lanes ?
There was a problem hiding this comment.
this fix will resolve that: sonic-net/sonic-sairedis#865
There was a problem hiding this comment.
Sure. I'll the try your fix and hopefully close this PR thereafter. Thanks.
Yes, the ports having the same SAI_PORT_ATTR_HW_LANE_LIST are from different switches. The error is It is happening under the setup of using one syncd process and one context to serve 8 phys. I'll investigate further why it happens. |
|
my fix on sairedis meta addresses this issue, you can close this issue here, and move it to sairedis issues, since related to sairedis not SAI |
|
The issue is fixed by sonic-net/sonic-sairedis#865. |
The reason is that we are using one syncd process to support multiple phy chips and for the ports from different phys, they may
have the same value on SAI_PORT_ATTR_HW_LANE_LIST.
This change is depended by sonic-net/sonic-buildimage#8146. Specifically, multiple switches are defined under guid 1 as below, however, ports from different switches may have the value on SAI_PORT_ATTR_HW_LANE_LIST.
{
"guid" : 1,
"name" : "phys", "dbAsic" : "GB_ASIC_DB",
"dbCounters" : "GB_COUNTERS_DB",
"dbFlex": "GB_FLEX_COUNTER_DB",
"dbState" : "STATE_DB",
"zmq_enable" : false,
"zmq_endpoint": "tcp://127.0.0.1:5565",
"zmq_ntf_endpoint": "tcp://127.0.0.1:5566",
"switches": [
{
"index" : 0,
"hwinfo" : "mdio0_0_0/0"
},
{
"index" : 1,
"hwinfo" : "mdio1_0_0/0"
}
}
Signed-off-by: Boyang Yu [email protected]