Updates to SRv6 programming model and related objects/attributes#1231
Updates to SRv6 programming model and related objects/attributes#1231abdosi merged 10 commits intoopencomputeproject:masterfrom
Conversation
Signed-off-by: Ashutosh Agrawal <[email protected]>
Signed-off-by: Ashutosh Agrawal <[email protected]>
Signed-off-by: Ashutosh Agrawal <[email protected]>
…_sid attribute list to get tunnel termination properties like TTL/DSCP mode 3) Changed IPv6 address to IP prefix in Local SID entry based on review feedback Signed-off-by: Ashutosh Agrawal <[email protected]>
…innsertion function Signed-off-by: Ashutosh Agrawal <[email protected]>
|
@rck-innovium , @marian-pritsak - would you like to review this? Thanks. |
|
@Israel-Meilik - please help review/approve. Thanks. |
|
@skraza - please help review, thanks. |
Signed-off-by: Ashutosh Agrawal <[email protected]>
caizhenghui-juniper
left a comment
caizhenghui-juniper
left a comment
There was a problem hiding this comment.
Tunnel id is for encapsulation not decapsulation
@caizhenghui-juniper local_sid entry has tunnel id for decap and nexthop entry will have tunnel id for encap. SAI application can use appropriate tunnel_id to set both encap/decap attributes for features like ttl/qos modes. |
|
@ashutosh-agrawal ok, got it. |
skraza
left a comment
skraza
left a comment
There was a problem hiding this comment.
PR#1 approved. Some comments to be discussed/addressed in PR#2.
Israel-Meilik
left a comment
Israel-Meilik
left a comment
There was a problem hiding this comment.
PR#1 reviewed by Broadcom team and approved.
Thanks.
Signed-off-by: Ashutosh Agrawal <[email protected]>
ashutosh-agrawal
force-pushed
the
srv6
branch
2 times, most recently
from
1ed9baf to
267f95c
Compare
…o renamed local_sid to my_sid based on community feedback. Signed-off-by: Ashutosh Agrawal <[email protected]>
|
Based on community meeting discussion there were 2 major points: 1> No need to address Backward Compatibility for SRv6 since feature has evolve lot when SAI api were design intially. There were agreement to approve/merge this PR as there was no outstanding issue. |
|
@ashutosh-agrawal Can you please add details in PR description above. We can merge after that. |
@abdosi In the PR description, I've added a list of items which were deferred (as discussed in the SRv6 WG). |
|
@abdosi Please let me know if anything else needs to be done to get this PR to merge. |
|
thanks . will merge this when PR check passes |
|
@ashutosh-agrawal do we have vslib code change which uses old segmentroute sid list in the code before moving the pointer of SAI in sonic to avoid build break? |
|
@abdosi are all the code PRs merged? Can you please update the code PRs by following example sonic-net/SONiC#806? |
10 participants
Changes are listed in the attached md file.
Following items were deferred and will be addressed in subsequent PRs: