Query statistics capability#1148
Merged
rlhui merged 11 commits intoopencomputeproject:masterfrom Nov 24, 2020
Merged
Conversation
Add ability to query statistics values capability per object type - meaning which statistics enum values are implemented per object type Currently, these is not exposed, and in order to check capabilities, the user has to retry each value, one by one Signed-off-by: Itai Baz <[email protected]>
kcudnik
approved these changes
Oct 31, 2020
lguohan
reviewed
Nov 5, 2020
Added additional param with list of implemented stats modes Signed-off-by: Itai Baz <[email protected]>
Collaborator
|
@JaiOCP please help review/approve |
lguohan
approved these changes
Nov 12, 2020
Signed-off-by: Itai Baz <[email protected]>
Signed-off-by: Itai Baz <[email protected]>
Signed-off-by: Itai Baz <[email protected]>
Signed-off-by: Itai Baz <[email protected]>
Collaborator
|
lgtm |
kcudnik
reviewed
Nov 12, 2020
kcudnik
approved these changes
Nov 12, 2020
Signed-off-by: Itai Baz <[email protected]>
Signed-off-by: Itai Baz <[email protected]>
Signed-off-by: Itai Baz <[email protected]>
Collaborator
|
WARNING: found trailing spaces in serialize.pm:255: } |
kcudnik
approved these changes
Nov 12, 2020
JaiOCP
suggested changes
Nov 13, 2020
Contributor
JaiOCP
left a comment
JaiOCP
left a comment
There was a problem hiding this comment.
Reduce stat_modes to 32bits given that there are only 2 modes and we do not expect to expand to a large value. 64bit will waste memory for large query sets
Signed-off-by: Itai Baz <[email protected]>
Signed-off-by: Itai Baz <[email protected]>
abdosi
approved these changes
Nov 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ability to query statistics values capability per object type - meaning which statistics enum values are implemented per object type
Currently, these is not exposed, and in order to check capabilities, the user has to retry each value, one by one
Signed-off-by: Itai Baz [email protected]