Fix linker error when compiling SAI RPC server.#1093
Merged
lguohan merged 5 commits intoopencomputeproject:masterfrom Jun 2, 2020
smaheshm:master
Merged
Fix linker error when compiling SAI RPC server.#1093lguohan merged 5 commits intoopencomputeproject:masterfrom smaheshm:master
lguohan merged 5 commits intoopencomputeproject:masterfrom
smaheshm:master
Conversation
* update loop counter
The variable was not part of the librpcserver.a library.
lguohan
reviewed
Jun 2, 2020
lguohan
approved these changes
Jun 2, 2020
lguohan
pushed a commit
that referenced
this pull request
Jun 2, 2020
The variable was not part of the librpcserver.a library. Moved the variable to the source file that's added in librpcserver.a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The variable was not part of the librpcserver.a library. Moved the variable to the source file that's added in librpcserver.a.