Feat: Add support for pattern properties#2288
Conversation
👷 Deploy request for openapi-ts pending review.Visit the deploys page to approve it
|
🦋 Changeset detectedLatest commit: b5ccff0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@gzm0 yes please feel free to review! The round-robin assignment was only meant to divide the PR reviews among us evenly, but always feel free to jump in and stamp a PR if you have context/time |
|
Any more movement on this? |
hontas
force-pushed
the
pattern-properties
branch
from
b299279 to
50ad586
Compare
|
@gzm0 thanks for the feedback! |
…repo and enhance type definitions in v2 and v3 schemas Until openapi-ts/openapi-typescript#2288 is merged we can use a fork to have the patternProperties openapi spec included into the generated typing
gzm0
left a comment
gzm0
left a comment
There was a problem hiding this comment.
Nice! Sorry for the delay on this one.
The behavior looks good. There is just a control flow concern. Then I think we can ship this.
|
@gzm0 no worries. Good catch - updated 👍 |
4 participants
Changes
Add support for patternProperties in addition to additionalProperties (#754).
Building on the work of @gzm0 in 1901 by adding tests
Ran the command
pnpm run update:exampleswhich created 129 new files and updated 69, none of which seemed related to this change. Let me know if you wan't me to do it anyways.How to Review
Refer to comments in original PR 1901
Validate tests are satisfactory
Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)