Skip to content

Conversation

@seratch
Copy link
Member

@seratch seratch commented Dec 3, 2025

This pull request adds a missing option for web search tool initialization. See https://platform.openai.com/docs/guides/tools-web-search?api-mode=responses#live-internet-access for details.

@seratch seratch requested a review from rm-openai December 3, 2025 03:55
@seratch seratch added enhancement New feature or request feature:core labels Dec 3, 2025
@seratch seratch added this to the 0.6.x milestone Dec 3, 2025
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 475 to 479
"filters": tool.filters.model_dump() if tool.filters is not None else None, # type: ignore [typeddict-item]
"user_location": tool.user_location,
"search_context_size": tool.search_context_size,
"external_web_access": tool.external_web_access,
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Stop sending null external_web_access flag

The new external_web_access option is always included in the payload, even when left at its default None, so every WebSearchTool() call now emits "external_web_access": null (openai_responses.py lines 475‑479). The Responses API expects a boolean and defaults to live access when the field is omitted; sending null will reject the request or bypass the documented default, breaking existing callers that don’t set the flag. The converter should skip the field when it is unset.

Useful? React with 👍 / 👎.

@seratch seratch marked this pull request as draft December 3, 2025 05:24
@seratch
Copy link
Member Author

seratch commented Dec 3, 2025

It's documented but the SDKs are not yet ready; converted to draft for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request feature:core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants