fix(agents-core): handle invalid JSON in tool call arguments gracefully#887
Merged
seratch merged 8 commits intoopenai:mainfrom Jan 20, 2026
Merged
Conversation
When the LLM generates malformed JSON for tool_calls arguments, the agent would crash with an unhandled SyntaxError. This change catches JSON parsing errors in executeFunctionToolCalls and returns a user-friendly error message instead, allowing the agent to continue running and potentially retry. The fix introduces: - Safe argument parsing that catches JSON/Zod parse errors - Error result builder that returns a helpful message to the model - Test case reproducing the exact issue scenario
- Remove redundant JSDoc comments (self-documenting types/functions) - Remove unnecessary `as const` assertion - Remove redundant inline test comments
🦋 Changeset detectedLatest commit: f2940f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
seratch
added
enhancement
seratch
approved these changes
Jan 20, 2026
seratch
reviewed
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes agent crashes when the LLM returns malformed JSON in tool_calls arguments (e.g.,
{"{"tagIds":...).The fix catches JSON parse errors in
toolExecution.tsand returns a clear error message to the model instead of crashing. This lets the agent recover and retry with valid JSON.Verification
Environment: macOS (arm64)
Runtime: Node.js v24.11.1
pnpm install pnpm testAll tests pass (95 test files, 964 tests).
Fixes #723